Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): allow providing custom configuration #1055

Merged
merged 1 commit into from
Jul 20, 2023
Merged

feat(cli): allow providing custom configuration #1055

merged 1 commit into from
Jul 20, 2023

Conversation

odinr
Copy link
Collaborator

@odinr odinr commented Jul 20, 2023

  • allow specifying mode when creating config
  • load config file from cwd
  • add cli options for custom config
  • update documentation for CLI

Why

Allow user to provide custom vite config, this config is merged (not replace) with framework generated config.

closes: #997

Check off the following:

  • Confirm that I checked changes to branch which I am merging into.

    • I have validated included files
    • My code does not generate new linting warnings
    • My PR is not a duplicate, check existing pr`s
  • Confirm that the I have completed the self-review checklist.

  • Confirm that my changes meet our code of conduct.

Conditional

  • Confirm project selected and category, actual, iteration are set
  • Confirm Milestone selected (if any)

* allow specifying mode when creating config
* load config file from cwd
* add cli options for custom config
* update documentation for CLI
@odinr odinr requested a review from a team as a code owner July 20, 2023 11:21
@changeset-bot
Copy link

changeset-bot bot commented Jul 20, 2023

🦋 Changeset detected

Latest commit: d815810

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@equinor/fusion-framework-cli Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added 💾 CLI fusion framework CLI 📚 documentation Improvements or additions to documentation 🚀 feature New feature or request labels Jul 20, 2023
@odinr odinr self-assigned this Jul 20, 2023
@odinr odinr merged commit 6c2fd59 into main Jul 20, 2023
7 checks passed
@odinr odinr deleted the issue/997 branch July 20, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💾 CLI fusion framework CLI 📚 documentation Improvements or additions to documentation 🚀 feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vite build options not available
1 participant