WSTAT warning and default well status #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an atribute called faults, so I consider it is better to ask for the atribute than to ask if it was instancieated
… understand why it doesnt apears in my master repo
|
I'll do the code styling later |
|
This looks good @tayloris 🎉 As discussed, a small minor change suggested, then this is ready for merge 🚀
|
anders-kiaer
requested changes
Jul 2, 2020
anders-kiaer
changed the title
anders-kiaer
approved these changes
Jul 2, 2020
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #69.
I include a warning message to let the user know well status are set OPEN by default.
However the message appears at the beginning of the run and I don't like the way is presented, so feel free to comment on that. we can discuss it on the meeting tomorrow.