Bugfix/add missing bounds check for findIndex #3565
Conversation
mhwaage
commented
Jul 29, 2024
mhwaage
commented
- Adds a bounds check for Autocomplete's findIndex, to prevent infinite recursion once the index has gone beyond bounds.
- Adds test to prevent regression
fixes an issue where a optionsDisabled function that would return true for an undefined value would crash from infinite recursion
|
fixes #3566 |
| @@ -331,6 +331,28 @@ describe('Autocomplete', () => { | |||
| expect(input).toHaveValue('') | |||
| }) | |||
|
|
|||
| it('Correctly handles keypresses up/down when all options are disabled', async () => { | |||
There was a problem hiding this comment.
I didn't add it here, because of scope creep, but i suppose that a test case with a large amount (>10000) of contiguous disabled options would still fail in the same manner.
|
I thought this had been fixed by #3534 but I guess I missed something? I'll take a look when i return from vacation next week! |
Possible that I implemented this fix on an outdated version, I will verify! |
#3534 fixes some of the issues but still misses edge cases. I will update the tests to cover those edge cases. |
|
I was trying to reproduce the edge case but think i found another one instead.
|
Yeah, this is the same edge case that this PR should be fixing. Is it not fixed by this pr? |
My mistake, the error was in the story 🤦♂️ |
