fix: improves type safty for autocomplete when optionLabel is required #3408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FredrikMWold
requested review from
vnys,
oddvernes and
torleifhalseth
as code owners
oddvernes
requested changes
Apr 29, 2024
packages/eds-core-react/src/components/Autocomplete/Autocomplete.tsx
Outdated
Show resolved
Hide resolved
|
Linting and tests are passing fine locally so disregard the failing github actions 👍 |
FredrikMWold
force-pushed
the
improve_autocompelete_type_safety
branch
from
a167356
to
cc861c5
Compare
oddvernes
requested changes
Apr 30, 2024
|
This resolves #3007 |
oddvernes
added a commit
that referenced
this pull request
Jun 13, 2024
oddvernes
added a commit
that referenced
this pull request
Jun 14, 2024
mhwaage
pushed a commit
to mhwaage/design-system
that referenced
this pull request
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves autocomplete type safety.
The way it works now is that if the options are different from an array of strings then
optionLabelis required. Typescript does not inform the user of this and the only feedback you get is a thrown error when you try and open the dropdown.This PR makes it so that the
optionLabelis optional if the options is an array of string, if notoptionLabelbecomes required.