fix: 🐛 fix pr label unrender (#471)

* fix: 🐛 fix pr label unrender * ci:
equinor · Aug 14, 2023 · f43a624 · f43a624
1 parent 51a8ed3
commit f43a624
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/.github/workflows/pr-deploy.yml b/.github/workflows/pr-deploy.yml
@@ -37,4 +37,4 @@ jobs:
 
       - name: 'Deploy affected apps to Fusion'
         shell: bash
-        run: npx turbo run pr:deploy --since origin/main -- --token ${{ env.FUSION_TOKEN }} --pr ${{ github.event.number }}
+        run: npx turbo run pr:deploy --since origin/main -- --token ${{ env.FUSION_TOKEN }} --pr ${{ github.event.pull_request.number }}
diff --git a/libs/shared/src/packages/fusion-framework/createRender.tsx b/libs/shared/src/packages/fusion-framework/createRender.tsx
@@ -48,9 +48,11 @@ export function createRender(
 
     const possiblePrNumber = (args.env.config?.environment as any)?.pr;
 
+    let cleanup = () => {};
+
     if (possiblePrNumber) {
       console.log(`creating pr ${possiblePrNumber}`);
-      createPrLabel(possiblePrNumber, el);
+      cleanup = createPrLabel(possiblePrNumber, el);
     }
 
     /** Create root from provided element */
@@ -69,6 +71,7 @@ export function createRender(
     return () => {
       teardown && teardown();
       root.unmount();
+      cleanup();
     };
   };
 }