Implement Access Keys for Exchangerates.host #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macanudo527
force-pushed
the
implement_access_keys
branch
2 times, most recently
from
61cab14
to
2b0ff4e
Compare
macanudo527
force-pushed
the
implement_access_keys
branch
4 times, most recently
from
828c379
to
4392e35
Compare
macanudo527
force-pushed
the
implement_access_keys
branch
from
4392e35
to
6de332a
Compare
|
@eprbell It took some finagling, but I got vcrpy to work. It does not really like Python < 3.10. The package itself is amazing. It really speeds things up and is easy to use. It cuts down on a lot of bulky mocking code. |
eprbell
reviewed
Oct 7, 2023
eprbell
requested changes
Oct 15, 2023
|
@eprbell Sorry about the confusion. I should have made a comment instead of pushed the request review button. I've been snowed over with this new job at times. I was in a rush. Hopefully, this is all good to go now. Let me know if you need anything else. After this gets rolled through, I'll try to rebase the pricing correction #207 and then if we rebase #203 it should also go green. |
eprbell
approved these changes
Oct 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will significantly speed up testing and make them more performant. It adds Vcrpy to Dali-RP2, so that we can mock HTTP requests as well as adds support for the now necessary access keys for the fiat pricing provider Exchangerates.host.
Fixes #211