Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation of the com module #118

Closed
Quantalabs opened this issue Jan 6, 2022 · 2 comments · Fixed by #119
Closed

Deprecation of the com module #118

Quantalabs opened this issue Jan 6, 2022 · 2 comments · Fixed by #119
Assignees
@Quantalabs
Labels
enhancement New feature or request release Version changes repo Repo management - issue template, workflows, etc. src Directly related to the source code of the package Status: Claimed Issue has been claimed wontfix This will not be worked on

Comments

@Quantalabs
Copy link
Member

As EpiJS grows more and more advanced, the uses for the com module grow smaller and smaller, and it makes it increasingly clear that we might need to deprecate the com module moving forward. There is an option of making this a completely separate package which would allow much more complex stats to be implemented. However, I do believe we should deprecate this in the v3 release.
@Quantalabs Quantalabs added enhancement New feature or request wontfix This will not be worked on src Directly related to the source code of the package Status: Claimed Issue has been claimed repo Repo management - issue template, workflows, etc. release Version changes labels Jan 6, 2022
@Quantalabs Quantalabs self-assigned this Jan 6, 2022
@quantum9Innovation
Copy link
Member

Looks good (let's move this to a new package). 📦

Quantalabs added a commit that referenced this issue Jan 6, 2022
@Quantalabs
[Deprecation] Deprecate com module (#118)
a93dd03
@Quantalabs
Copy link
Member Author

Completed in 9a55d2f

@Quantalabs Quantalabs mentioned this issue Jan 7, 2022
Merged
4 tasks
Quantalabs added a commit that referenced this issue Jan 7, 2022
@Quantalabs @quantum9Innovation
v3.0.0-alpha.0 (#119)
6117e2b 
* Convert pre-compiled model structures to `model` class

* Rebuild code

* Replace var with let

* Add plotting with plotly for NodeJS (not for HTML)

* Fix plotting with `com` module and rebuild code

* Add plotting in the Web

* Fix tests for plotly

* [Deprecation] Deprecate `com` module (#118)

* Rebuild code

* Add documentation

* Update documentation

* Version Bump and Docs Rebuild

* Apply suggestions from code review

Co-authored-by: q9i <46249765+quantum9Innovation@users.noreply.github.com>

* Remove unnecassary variable and rebuild code

Co-authored-by: q9i <46249765+quantum9Innovation@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Quantalabs Quantalabs

Labels
enhancement New feature or request release Version changes repo Repo management - issue template, workflows, etc. src Directly related to the source code of the package Status: Claimed Issue has been claimed wontfix This will not be worked on
Projects
EpiJS v3 Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v3.0.0-alpha.0 epispot/EpiJS
2 participants
@quantum9Innovation @Quantalabs