Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VaPopover): Fixed closing other hover popovers on mouse leave #4301

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Fsss126
Copy link
Contributor

@Fsss126 Fsss126 commented Jun 2, 2024

closes #4250

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

@m0ksem
Copy link
Collaborator

m0ksem commented Jun 3, 2024

Looks like we need to check if new item under hover is also dropdown/popover instead of having a prop...

We can utilize useCache and have a property like "dropdown under hover" ID and check if there is another dropdown under hover, we do not move focus.

Copy link
Collaborator

@m0ksem m0ksem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having extra prop doesn't seem as proper solution for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hover popovers close all hover popovers on mouse leave
2 participants