-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inherit root context information in ShallowWrapper::shallow() #2296
Conversation
@ljharb FYI |
@ljharb could you please take a look? 😁 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks great!
@@ -1683,7 +1698,7 @@ class ShallowWrapper { | |||
* @param {Object} options | |||
* @returns {ShallowWrapper} | |||
*/ | |||
dive(options = {}) { | |||
dive(options) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the options are optional, so the default value is correct (this change would change the length of the function)
dive(options) { | |
dive(options = {}) { |
6bc081c
to
696a272
Compare
New Stuff - `render`: handle Fiber strings and numbers (#2221) Fixes - `shallow`: Share child context logic between `shallow` and `dive` (#2296) - `mount`: `children`: include text nodes ($2269) - `mount`: `invoke`: use adapter’s `wrapInvoke` if present (#2158) Docs - `mount`/`shallow`: `closest`/`parent`: Add missing arguments description (#2264) - `mount`/`shallow`: fix pluralization of “exist” (#2262) - `shallow`/`mount`: `simulate`: added functional component example to simulate doc (#2248) - `mount`: `debug`: add missing verbose option flag (#2184) - `mount`/`shallow`: `update`: fix semantics description (#2194) - add missing backticks to linked method names (#2170) - `invoke`: Add missing backticks to end of codeblock (#2160) - `invoke`: Fix typo (#2167) - Explicit React CSS selector syntax description (#2178) Meta Stuff - [meta] add `funding` field - [meta] Update airbnb.io URLs to use https (#2222) - [deps] update `is-boolean-object`, `is-callable`, `is-number-object`, `is-string`, `enzyme-shallow-equal`, `array.prototype.flat`, `function.prototype.name`, `html-element-map`, `is-r egex`, `object-inspect`, `object-is`, `object.entries`, `object.vales`, `raf`, `string.prototype.trim` - [dev deps] update `eslint`, `eslint-plugin-import`, `eslint-plugin-markdown`, `eslint-plugin-react`, `safe-publish-latest`, `eslint-config-airbnb`, `rimraf`, `safe-publish-latest`, `k arma-firefox-launcher`, `babel-preset-airbnb`, `glob-gitignore`, `semver`, `eslint-plugin-jsx-a11y`
Fixes #2290