Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renderProp followup (doc corrections & console.log removal) #1890

Merged
merged 2 commits into from
Nov 7, 2018
Merged

renderProp followup (doc corrections & console.log removal) #1890

merged 2 commits into from
Nov 7, 2018

Conversation

dferber90
Copy link
Contributor

@dferber90 dferber90 commented Nov 6, 2018

I found some issues while reviewing #1863 after it was merged. This follow-up resolves them.

If we accept #1891 we don't need to merge this PR as those fixes are contained in there as well.

@dferber90

This comment has been minimized.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ljharb ljharb merged commit d6383d5 into enzymejs:master Nov 7, 2018
ljharb added a commit that referenced this pull request Nov 8, 2018
 - [new] add `wrapWithSimpleWrapper` (#1863, #1890)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants