Compatibility with future jasmine versions #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgravrock
changed the title
sgravrock
commented
Oct 16, 2021
| ) => { | ||
| const customEqualityTesters = |
There was a problem hiding this comment.
This can be removed if compatibility with jasmine 3.5 and earlier is not wanted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to Jasmine 3.6, matchers that wanted to support custom equality testers had to accept them as an argument to the matcher factory and pass them to MatchersUtil#equals and MatchersUtil#contains. That's not required beginning with 3.6. It'll produce a deprecation warning in 3.99 and fail in 4.0. This PR updates jasmine-enzyme to be compatible with the planned changes in Jasmine 3.99 and 4.0, while maintaining compatibility with older versions.
Additional context:
https://jasmine.github.io/tutorials/upgrading_to_Jasmine_4.0#matchers-cet
I've tested this by running a usage of toHaveState that relies on custom equality testers against the following versions of the
jasminepackage:3.5.0github:jasmine/jasmine-npm#3.99github:jasmine/jasmine-npm#4.0