Add jest-environment-jsdom to peer deps #346
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Whoaa512 would you please restore the branch? i need to keep both PRs open and in sync to avoid polluting the repo with the PR ref. |
|
This is a duplicate as you've said. I'm trying to close out stale PRs that have seen no movement and this seems superseded by the 2 other PRs linked |
|
Yes, but the PR ref will remain as a permanent mark on the repo, whereas if this PR can be left open, then I can update all three PRs to the same sha and land them all at once, later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is blocking a jest upgrade we're doing, since multiple copies of the jest-environment-jsdom is producing errors in our tests.
The other PR(#343) for this seems stalled out.