AttributesGroups deep equality test (speed up selection) #262
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default AttributesGroups equality test is == on a List, which returns false even if the contents are equal. The impact of this is that Operator.update() will always think the AttributesGroups have changed after a selection, regardless of whether or not there was a real change.
Implementing equal value for AttributesGroups using deepCollectionEquals allows update() to return false when the graph content hasn't changed. This short-circuits re-rendering as designed.
For a complex graph that uses tooltips but does not change other Attributes on selection, this improves the effective framerate by about 8x.