-
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement RegExp Match Indices proposal #99
Conversation
The diff is easier to see with |
// TODO: add this to spec text. | ||
groupNames.push(Value.undefined); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without this, the access to the values in groupNames will be off by one in MakeIndicesArray
// TODO: fix spec text. | ||
Assert(e >= 0/* && e < Input.length */); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e
can be >= Input.length
/cc @rbuckton. I think I found two small bugs in the spec text. |
c1af96c
to
84ab9fb
Compare
@targos can you file issues for the bugs on https://github.com/tc39/proposal-regexp-match-indices/issues? |
@rbuckton done! |
Refs: https://tc39.es/proposal-regexp-match-indices/