Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SWTCH-2438 transfer domains #707

Merged
merged 7 commits into from
Jul 7, 2023
Merged

SWTCH-2438 transfer domains #707

merged 7 commits into from
Jul 7, 2023

Conversation

JGiter
Copy link
Collaborator

@JGiter JGiter commented Jun 30, 2023 •
edited
Loading

Description

  • Since domains.ts became too big it was split on transfer-domains, update-domains and init-domains

Contributor checklist

  • Breaking changes - check for any existing interfaces changes that are not backward compatible, removed method etc.
  • Documentation - document your code, add comments for method, remember to check if auto generated docs were updated.
  • Tests - add new or updated existed test for changes you made.
  • Migration guide - add migration guide for every breaking change.
  • Configuration correctness - check that any configuration changes are correct ex. default URLs, chain ids, smart contract verification on Volta explorer or EWC explorer.

@JGiter JGiter force-pushed the SWTCH-2438_transfer_domains branch from 1395fc7 to 1142c8a Compare June 30, 2023 09:41
@JGiter JGiter force-pushed the SWTCH-2438_transfer_domains branch 8 times, most recently from 5835b3e to d10f3be Compare July 3, 2023 06:30
@JGiter JGiter force-pushed the SWTCH-2438_transfer_domains branch from d10f3be to 81d5bb9 Compare July 3, 2023 06:40
@JGiter JGiter force-pushed the SWTCH-2438_transfer_domains branch from a72f43a to 8ed055f Compare July 4, 2023 07:25
@JGiter JGiter force-pushed the SWTCH-2438_transfer_domains branch from 8ed055f to 3ebbe3d Compare July 4, 2023 08:22
@JGiter JGiter marked this pull request as ready for review July 7, 2023 13:42
jrhender
jrhender approved these changes Jul 7, 2023
View reviewed changes
Copy link
Collaborator

@jrhender jrhender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JGiter

@JGiter JGiter merged commit 8929d5e into develop Jul 7, 2023
5 checks passed
@JGiter JGiter deleted the SWTCH-2438_transfer_domains branch July 7, 2023 13:45
@ewf-devops
Copy link

🎉 This PR is included in version 8.0.1-alpha.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ewf-devops
Copy link

🎉 This PR is included in version 8.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrhender jrhender jrhender approved these changes

Assignees
No one assigned
Labels
released on @canary released on @latest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JGiter @ewf-devops @jrhender