Shield background tasks #1654
Shield background tasks #1654
Conversation
| with anyio.CancelScope(shield=True): | ||
| for task in self.tasks: |
There was a problem hiding this comment.
Could we make this opt in on a per-task basis? For backwards compatibility and because I don't think in some cases it does make sense to cancel the background task if the client closes the connection.
There was a problem hiding this comment.
Business logic. Like if you're doing something that is expensive and you don't care if it succeeds or fails if the client closes the connection. No specific use case in mind, just thinking in general.
Although now I realize this is even more complicated because the behavior changes depending on if there is a BaseHTTPMiddleware involved, right? What happens if there isn't a BaseHTTPMiddleaware involved? Does it depend on the ASGI server?
There was a problem hiding this comment.
fails if the client closes the connection
bkg tasks runs after the response 🤔
There was a problem hiding this comment.
Sorry I was maybe getting a bit confused as to what actually causes the issue.
| for task in self.tasks: | ||
| await task() | ||
| async with anyio.create_task_group(): | ||
| with anyio.CancelScope(shield=True): |
There was a problem hiding this comment.
Is this task group needed? I think just the cancel scope should be enough.
|
This is not what we want. 😞 Trying to fix issues of |
I'm not sure if we should be touching
BackgroundTasks.This PR allows
BackgroundTasksto run until they finish.