Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that ASGI 'raw_path' does not include query component of URL. #2999

Merged
merged 5 commits into from
Dec 11, 2023

Conversation

tomchristie
Copy link
Member

@tomchristie tomchristie commented Dec 11, 2023

Closes #2810.

Update the ASGI transport to ensure that raw_path does not include the query component.

The spec was originally a little ambiguous here, and it might(?) have made sense for it to include the query portion, since that way around it'd be a direct representation of the HTTP/1.1 target byte string that was received on the wire. But the spec's been clarified since, and we're not matching that correctly at the moment. Let's fix that! ☺️

@tomchristie tomchristie marked this pull request as ready for review December 11, 2023 14:32
@tomchristie tomchristie merged commit 90538a3 into master Dec 11, 2023
5 checks passed
@tomchristie tomchristie deleted the fix-asgi-rawpath branch December 11, 2023 15:45
@tomchristie tomchristie mentioned this pull request Dec 14, 2023
@karpetrosyan karpetrosyan mentioned this pull request Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ASGI raw_path scope key should not include the query string portion.
2 participants