Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't raise exceptions on graceless close cases #310

Merged
merged 1 commit into from
Apr 28, 2021

Conversation

tomchristie
Copy link
Member

When a connection fails to close gracefully we're currently raising exceptions.
Actually I really don't think we want to be doing that.

An exception raised during connection close means that the connection wasn't terminated gracefully, but it will still be terminated. Raising exceptions here just means that:

  • We can have cases where a request/response cycle runs to completion, but the client library will raise an exception because an unclean close occurred.
  • We can have cases where an exception occurs on issuing a request against the connection pool, where we tear down an expired keep alive connection before issuing a fresh request, but an exception ends up being raised.
  • We're closing a client and an exception is raised, that we really don't want to occur.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant