-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Abort SSL connections on close, rather than waiting for remote EOF. #167
Conversation
I looked at https://badssl.com to see if they had a public endpoint for this scenario, but it doesn't seem so (only mostly scenarios for certs-related issues). |
All AnyIO backends should do this properly when |
@agronholm Grand - good to know. Any pointers on good ways to test our behaviour before/after this fix? |
If the client SSLSocket is receiving an unexpected EOF, it should raise |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we really need to do that.
As an alternative we can introduce a "close"
timeout as the "connect"
timeout we already have which can be fired as a last resort
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. Ideally we'd be adding some tests as Tom suggested in PR description, but I'm also happy enough to merge and release and see if anything breaks. :-)
I think, I hit this problem (probably it was exactly this unclosed socket) while I tried to write the test for #235 |
I'm hitting some problems potentially caused by this change: encode/httpx#1459 Any ideas? |
In order to close encode/httpx#825 and encode/httpx#914
Probably needs tests to check that: