-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve coreapi importing #5921
Improve coreapi importing #5921
Conversation
Please release a new version on PyPI as soon as this PR is merged ;) Thanks for the work |
@carltongibson I hope I opened this PR in the right way, first time contributing 😅
Please let me know if you want a test for this, it didn't look like something you were testing generally. |
@gsvr Thanks for this. @ALL: This will go into a 3.8.2. There are a couple of issues for that, so it'll be first half of next week. If you cannot wait until then you should install directly from GitHub. (Pip has first-class support for this. It's not something to avoid.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. Looks good.
@carltongibson It's not a problem for me, I just pinned my version to |
v3.8.2 is now available on PyPI. Thanks all. |
@LuisHCK please, don't use passive aggressive tone. |
Description
Closes #5918
Import coreapi from rest_framework.compat, not directly.