-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change extra installations to specific drivers #436
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aminalaee
changed the title
change extra_requires
Change extra installations to specific drivers
Dec 10, 2021
@collerek Do you think you can review this? |
collerek
reviewed
Jan 16, 2022
@collerek thanks for the review. that makes sense. So instead of this: database = Database('sqlite:///example.db') We would use this in the docs: database = Database('sqlite+aiosqlite:///example.db') Even though both will work for now, but we wouldn't encourage the default drivers both in installation and usage. |
Merged
collerek
approved these changes
Jan 17, 2022
skuda
pushed a commit
to skuda/databases
that referenced
this pull request
Mar 31, 2022
This reverts commit c2417cd.
skuda
pushed a commit
to skuda/databases
that referenced
this pull request
Mar 31, 2022
This reverts commit c2417cd.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #429 and closes #421.
Changes extra installations from:
To:
This will be a step towards downplaying the default drivers.
Even though it keeps default drivers to work like
pip install databases[postgresql]
but will remove them from the docs to point to specific drivers.And also worth mentioning that this will be the API, still mentioned the default in the docs:
This is equivalent to:
I think we should also downplay the default dialect and specify the driver in the docs.