Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ember-data:deprecate-array-like deprecation #100

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

bartocc
Copy link
Contributor

@bartocc bartocc commented Dec 17, 2023

Use Array.prototype.slice instead of RecordArray.prototype.toArray

Needed by ember-learn/guides-source#1986

…of RecordArray.proto.toArray to fix ember-data:deprecate-array-like deprec
Copy link

netlify bot commented Dec 17, 2023

Deploy Preview for guidemaker ready!

Name Link
🔨 Latest commit 42b689e
🔍 Latest deploy log https://app.netlify.com/sites/guidemaker/deploys/657f3d6c2cf0a40008198bfd
😎 Deploy Preview https://deploy-preview-100--guidemaker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bartocc bartocc changed the title ♻️ refacto PageService.proto.pageTree: Use Array.proto.slice instead … 🚨 Fix ember-data:deprecate-array-like deprecation Dec 17, 2023
@bartocc bartocc marked this pull request as ready for review December 17, 2023 18:38
@mansona mansona changed the title 🚨 Fix ember-data:deprecate-array-like deprecation Fix ember-data:deprecate-array-like deprecation Dec 18, 2023
@mansona mansona added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Dec 18, 2023
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great 🎉 thanks

@mansona mansona merged commit e916c60 into empress:main Dec 18, 2023
15 of 20 checks passed
@github-actions github-actions bot mentioned this pull request Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants