classnames also accept undefined as value

[siuvdlec]

What:

Why:

How:

Checklist:

• Documentation
• Tests
• Code complete

[tkh44]

Would this need to support all of these types (undefined | null | boolean | string) as values?

[Ailrun]

We may need any, as described in #746.

[Andarist]

while any is technically correct I doubt we should actually recommend it, typings give us power to restrict usages to sane ones

[siuvdlec]

yes it's better with undefined | null | boolean | string

[emmatown]

Thanks!!

[osi-oswald]

Why was type number not added as well? Consider the following usecase:

cx('count', { isOdd: count % 2 }) // TS complains, emotion handles it just fine

I now have to type one of the following just to make TS happy again (which I find unnecessary):

cx('count', { Boolean(isOdd: count % 2) })
cx('count', { !!(isOdd: count % 2) })

Actually type any would really be the best type for it. Otherwise someone might come and ask "why did you not add type XXX as well"?

[Andarist]

Imho relaying on auto bool coercion for numbers there is not the best way to do. While it ofc works in JavaScript, type systems should strive to be more explicit about such things and I would consider the current lack of number support a good thing.