Fix tsconfig for emotion-theming #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ailrun
force-pushed
the
typings/fix-emotion-theming
branch
from
3a47170
to
0b9689e
Compare
mgroenhoff
reviewed
Jun 12, 2018
| "noImplicitAny": true, | ||
| "noImplicitThis": true, | ||
| "strict": true, |
There was a problem hiding this comment.
You can clean it up a bit now because of strict mode. You can remove noImplicitAny, noImplicitThis, strictNullChecks and strictFunctionTypes.
There was a problem hiding this comment.
I usually left them for clarity. Does this verbosity bother you? If that's the case, let's delete them in all tsconfig.jsons in a separate PR.
There was a problem hiding this comment.
It is a habit of mine to keep them as concise as possible. But that's just me. I'm leaving it up to you 👍
mgroenhoff
approved these changes
Jun 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: tsconfig.json for emotion-theming package
Why: It does not work well with dtslint
How: Fix options in tsconfig.json
Checklist:
Resolves #711.