Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Typescript definitions for 'create-emotion-server' and 'emotion-server' #692

Merged
merged 6 commits into from
Jun 5, 2018

Conversation

mgroenhoff
Copy link
Contributor

What: Typescript definitions added for create-emotion-server and emotion-server

Why: Because Typescript!

How:

Checklist:

  • Documentation N/A
  • Tests
  • Code complete N/A

@mgroenhoff
Copy link
Contributor Author

Please update yarn.lock and commit it yourself because I can't seem to get it to generate the correct registry (yarnpkg/yarn#3330)

@tkh44 tkh44 added the merge me! label Jun 4, 2018
"rules": {
"no-relative-import-in-test": false
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You miss the final linefeeding for this file

Copy link
Contributor Author

@mgroenhoff mgroenhoff Jun 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are many more tslint.json files without this line feed. Do you want me to add them to those as well?
Edit: I went ahead and did it anyway

@@ -20,8 +23,10 @@
"emotion": "^9.1.3"
},
"devDependencies": {
"@types/react-dom": "16.0.5",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should depend on @types/react-dom as dependencies, or, at least as peerDependencies, shouldn't it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only use is inside the tests so I don't think it should.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mgroenhoff Oh, you're right. My miss.

@emmatown emmatown merged commit cd2dc4f into emotion-js:master Jun 5, 2018
@mgroenhoff
Copy link
Contributor Author

Thanks!

@mgroenhoff mgroenhoff deleted the emotion-server-typings branch June 6, 2018 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants