Support shouldForwardProp in styled's options #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andarist
commented
Apr 5, 2018
| key !== 'theme' && key !== 'innerRef' | ||
| export const testAlwaysTrue = () => true | ||
|
|
||
| export const omitAssign: ( | ||
| export const pickAssign: ( |
There was a problem hiding this comment.
imho omit was misleading here, and pick is better suited because pickAssign actually picks properties if predicate (testFn) returns truthy, omit would pick them if predicate would return falsy
|
There are still some flow errors, it seems type inference doesnt handle this accurately. Let me know if u want this refactored or should I just use FlowFixMe? Kinda hating to adjust actual, valid, code just to satisfy inference algorithm |
|
Use FlowFixMe |
|
Done |
Codecov Report
|
tkh44
approved these changes
Apr 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #611
Checklist: