Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix source maps without a semicolon or newline after the last declaration #458

Merged
merged 1 commit into from
Nov 10, 2017

Conversation

emmatown
Copy link
Member

What:
Fix source maps without semicolon or newline

Why:
Closes #455

How:
Add a newline before the source map comment.

Checklist:

  • Documentation N/A
  • Tests
  • Code complete

cc @thysultan
It looks like Stylis removes declarations that have a comment after them without a newline or semicolon between the declaration and comment
https://codesandbox.io/s/7y5jwno541

Copy link
Member

@tkh44 tkh44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emmatown emmatown merged commit f93603d into master Nov 10, 2017
@emmatown emmatown deleted the fix-source-maps-without-newline-or-semicolon branch November 10, 2017 22:41
@thysultan
Copy link

The mention stylis bug should be fixed in 3.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sourcemaps break the css`` API
3 participants