Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert nested selectors differently #387

Merged
merged 6 commits into from
Oct 6, 2017
Merged

Conversation

emmatown
Copy link
Member

@emmatown emmatown commented Oct 6, 2017

What:

Insert nested selectors differently

Why:

It's smaller than #386 and should be faster(We need to add benchmarks for highly dynamic values).

How:

If a selector is a parent it inserts itself before the rule with the parent and removes itself from the selectorQueue and if its not a parent it just inserts itself after the previous rule

Checklist:

  • Documentation N/A
  • Tests
  • Code complete

@codecov
Copy link

codecov bot commented Oct 6, 2017

Codecov Report

Merging #387 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted Files Coverage Δ
packages/emotion/src/index.js 100% <100%> (ø) ⬆️

@emmatown emmatown requested a review from tkh44 October 6, 2017 23:28
@emmatown emmatown merged commit 299d3f9 into master Oct 6, 2017
@emmatown emmatown deleted the nested-selector-specificity branch October 6, 2017 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants