Make the theme prop always exist #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #364 +/- ##
==========================================
- Coverage 97.72% 97.72% -0.01%
==========================================
Files 22 22
Lines 660 658 -2
Branches 151 150 -1
==========================================
- Hits 645 643 -2
Misses 11 11
Partials 4 4
Continue to review full report at Codecov.
|
tkh44
approved these changes
Oct 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Make the theme prop always exist
Why:
Because otherwise when people are trying to use props.theme.something and there isn't a ThemeProvider they'll get cannot read property of undefined.
How:
Always do an assign for the theme prop.
Checklist: