Allow interpolation return value to be a function. #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
September 25, 2017 01:20
emmatown
reviewed
Sep 26, 2017
packages/emotion/src/index.js
Outdated
| @@ -116,6 +116,10 @@ function handleInterpolation( | |||
| return '' | |||
| } | |||
|
|
|||
| if (typeof interpolation === 'function') { | |||
| return interpolation() | |||
There was a problem hiding this comment.
I think this should be handleInterpolation(interpolation())
emmatown
approved these changes
Sep 26, 2017
Codecov Report
@@ Coverage Diff @@
## master #346 +/- ##
==========================================
+ Coverage 97.33% 97.34% +<.01%
==========================================
Files 17 17
Lines 562 564 +2
Branches 133 134 +1
==========================================
+ Hits 547 549 +2
Misses 11 11
Partials 4 4
Continue to review full report at Codecov.
|
tkh44
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Allow the return value of dynamic values to be a function. This function will be called with zero arguments.
Why:
@CompuIves has some really cool stuff in his theme.
https://github.com/CompuIves/codesandbox-client/blob/master/src/common/theme.js#L23-L30
How:
Just call the interpolation if it is a function
Checklist: