Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Move
emotion
andbabel-plugin-emotion
to peerDependencies where they're used in other packages.This also remove the aliases like
emotion/react
.emotion/macro
andreact-emotion/macro
are still the entry points for the macros though.emotion-utils
is still a direct dependency.Why:
it should solve #295.
Right now,
emotion
is a dependency ofemotion-server
and others so depending on the way package managers and bundlers do thingsemotion-server
may importemotion
from it's own node_modules so it won't have the styles in it's version of emotion.The same is also true for composition, for example using
styled
fromreact-emotion
andcss
fromemotion
andreact-emotion
will useemotion
from it's node_modules so the styles won't be in the caches.How:
Checklist: