Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move emotion to peerDependencies #322

Merged
merged 2 commits into from
Sep 22, 2017
Merged

Conversation

emmatown
Copy link
Member

What:
Move emotion and babel-plugin-emotion to peerDependencies where they're used in other packages.

This also remove the aliases like emotion/react. emotion/macro and react-emotion/macro are still the entry points for the macros though.

emotion-utils is still a direct dependency.

Why:
it should solve #295.

Right now, emotion is a dependency of emotion-server and others so depending on the way package managers and bundlers do things emotion-server may import emotion from it's own node_modules so it won't have the styles in it's version of emotion.

The same is also true for composition, for example using styled from react-emotion and css from emotion and react-emotion will use emotion from it's node_modules so the styles won't be in the caches.

How:

Checklist:

  • Documentation N/A
  • Tests N/A
  • Code complete

@codecov
Copy link

codecov bot commented Sep 22, 2017

Codecov Report

Merging #322 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #322   +/-   ##
=======================================
  Coverage   96.37%   96.37%           
=======================================
  Files          16       16           
  Lines         580      580           
  Branches      141      141           
=======================================
  Hits          559      559           
  Misses         16       16           
  Partials        5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eafedef...0b004ba. Read the comment docs.

@tkh44 tkh44 self-requested a review September 22, 2017 01:46
@emmatown emmatown merged commit 0def43c into master Sep 22, 2017
@emmatown emmatown deleted the move-to-peer-dependencies branch September 22, 2017 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant