Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SidePanel::rights with an exact_width have incorrect padding #4126

Closed
a99984b1799 opened this issue Mar 2, 2024 · 2 comments · Fixed by #4351
Closed

SidePanel::rights with an exact_width have incorrect padding #4126

a99984b1799 opened this issue Mar 2, 2024 · 2 comments · Fixed by #4351
Labels
bug Something is broken

Comments

@a99984b1799
Copy link

Describe the bug

SidePanel::right incorrectly pads the right side of the panel when it has an exact_width set.

To Reproduce

The following update function roughly implements the screenshot below:

fn update(&mut self, ctx: &egui::Context, _: &mut eframe::Frame) {
    egui::SidePanel::right("right").exact_width(100.).show(ctx, |ui| {
        ui.label("AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA");
    });
    egui::SidePanel::left("left").exact_width(100.).show(ctx, |ui| {
        ui.label("AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA");
    });
    egui::CentralPanel::default().show(ctx, |ui| { });
}

Screenshots

Desktop (please complete the following information):

  • OS: Linux.

Additional Information

As implied, the padding is correct when an exact_width is not given.

@a99984b1799 a99984b1799 added the bug Something is broken label Mar 2, 2024
@a99984b1799
Copy link
Author

Closely related to #3006, I wouldn't call it a duplicate but I'd be happy to close this if need be.

@RylanYancey
Copy link

I am also experiencing this problem! Here is what I'm seeing:

Screenshot from 2024-03-10 18-42-53

The 'saved moves' panel is being rendered on top of 'Nxf6' and the multiline text widget. Heres' my src:

Screenshot from 2024-03-10 18-44-39

(screenshot cuz my editor is being weird about copying)

I'm calculating what I want the width to be (40% of the screen space for the notes panel, and 10% for the moves panel), then assigning it by using exact_width(). However, this results in the aforementioned issue.

Thanks!
- Rylan Yancey

emilk pushed a commit that referenced this issue Apr 22, 2024
<!--
Please read the "Making a PR" section of
[`CONTRIBUTING.md`](https://github.com/emilk/egui/blob/master/CONTRIBUTING.md)
before opening a Pull Request!

* Keep your PR:s small and focused.
* The PR title is what ends up in the changelog, so make it descriptive!
* If applicable, add a screenshot or gif.
* If it is a non-trivial addition, consider adding a demo for it to
`egui_demo_lib`, or a new example.
* Do NOT open PR:s from your `master` branch, as that makes it hard for
maintainers to add commits to your PR.
* Remember to run `cargo fmt` and `cargo cranky`.
* Open the PR as a draft until you have self-reviewed it and run
`./scripts/check.sh`.
* When you have addressed a PR comment, mark it as resolved.

Please be patient! I will review your PR, but my time is limited!
-->

* Closes <#4126>
* Closes <#3006>

Previously, `SidePanel`/`TopBottomPanel` didn't include `inner_margin`
when setting the min width/height of `Frame`. As a result, when your
`Panel` has `inner_margin`, its size doesn't work as expected.

Before


![before](https://github.com/emilk/egui/assets/62168376/3bd20c0a-6625-4786-9f7d-85449a0e436c)

After


![after](https://github.com/emilk/egui/assets/62168376/a2e41ed4-4f20-484c-8b54-d2ce9cc71d95)
valadaptive pushed a commit to valadaptive/egui that referenced this issue Jun 20, 2024
<!--
Please read the "Making a PR" section of
[`CONTRIBUTING.md`](https://github.com/emilk/egui/blob/master/CONTRIBUTING.md)
before opening a Pull Request!

* Keep your PR:s small and focused.
* The PR title is what ends up in the changelog, so make it descriptive!
* If applicable, add a screenshot or gif.
* If it is a non-trivial addition, consider adding a demo for it to
`egui_demo_lib`, or a new example.
* Do NOT open PR:s from your `master` branch, as that makes it hard for
maintainers to add commits to your PR.
* Remember to run `cargo fmt` and `cargo cranky`.
* Open the PR as a draft until you have self-reviewed it and run
`./scripts/check.sh`.
* When you have addressed a PR comment, mark it as resolved.

Please be patient! I will review your PR, but my time is limited!
-->

* Closes <emilk#4126>
* Closes <emilk#3006>

Previously, `SidePanel`/`TopBottomPanel` didn't include `inner_margin`
when setting the min width/height of `Frame`. As a result, when your
`Panel` has `inner_margin`, its size doesn't work as expected.

Before


![before](https://github.com/emilk/egui/assets/62168376/3bd20c0a-6625-4786-9f7d-85449a0e436c)

After


![after](https://github.com/emilk/egui/assets/62168376/a2e41ed4-4f20-484c-8b54-d2ce9cc71d95)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants