-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend TypeDescription codegen with referenced type inclusion, disable option, raw sources #10
Extend TypeDescription codegen with referenced type inclusion, disable option, raw sources #10
Conversation
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
…of date Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note for reviewers - these files are the copied generated sources, so they give a good sense for what the templates do, since those are not super easy to read
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
e57ee67
to
f581176
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In short, I don't have much to say here; it looks generally good. I'll suggest we go ahead and merge this one into ros2#727 now, and run CI. I'll do one final pass on the combination before approving over there.
Part of ros2/ros2#1159
Bundled with (must be merged together):
Replaces (or extends) ros2#727. Key differences
type_support_t->get_type_hash_func
rather than bare valueget_type_description
andget_type_sources
take a typesupport struct argument (for use by dynamic types)Key features:
TYPE_HASH_TUPLES
to more accurateTYPE_DESCRIPTION_TUPLES
in cmakeget_type_description
,get_individual_type_description_source
, andget_type_description_sources
ROSIDL_GENERATOR_C_DISABLE_TYPE_DESCRIPTION_CODEGEN
rosidl_generator_type_description
to output a new structure oftype_description_msg
plus a flat list of all referenced types and their hashes at the time of generation. These hashes are used at runtime (in Debug builds) to detect ABI breaks when constructing type descriptions the first time