Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Production fastboot builds were incorrectly getting server code in the browser #974

Merged
merged 4 commits into from
Oct 7, 2021
Merged

Production fastboot builds were incorrectly getting server code in the browser #974

merged 4 commits into from
Oct 7, 2021

Conversation

thoov
Copy link
Collaborator

@thoov thoov commented Sep 20, 2021

Failing test case for #968

@thoov thoov changed the title Issue with production assets and "switchable" template Issue with fastboot production assets and "switchable" template Sep 21, 2021
@thoov thoov added the bug Something isn't working label Sep 22, 2021
@ef4
Copy link
Contributor

ef4 commented Oct 7, 2021

applyVariantToBabelConfig was mutating its input, which lived in the shared node require cache. So if the same file happened to get handed to the same worker thread for both fastboot and non-fastboot processing of the same file you'd get a polluted value of the babel config in the second one.

@ef4 ef4 merged commit 1606237 into embroider-build:master Oct 7, 2021
@ef4 ef4 changed the title Issue with fastboot production assets and "switchable" template Production fastboot builds were incorrectly getting server code in the browser Oct 11, 2021
@ef4 ef4 mentioned this pull request Nov 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thoov @ef4