Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infinite loop in local testing scenario building #869

Merged
merged 1 commit into from
Jun 22, 2021

Conversation

krisselden
Copy link
Contributor

No description provided.

@@ -9,7 +9,7 @@ import { dirname, delimiter } from 'path';
if (!voltaHome) return;
let paths = process.env['PATH']!.split(delimiter);
while (/\.volta/.test(paths[0])) {
paths.shift;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

someone was trying to write some ruby.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't notice the typo and copied it verbatim from volta-cli/volta#702.

We also found and fixed this in ember-auto-import, but not before it got copied to here. 🙃

@stefanpenner stefanpenner merged commit 4faf796 into embroider-build:master Jun 22, 2021
@rwjblue rwjblue changed the title fix infinite loop Fix infinite loop in local testing scenario building Jun 23, 2021
@krisselden krisselden deleted the fix-infinite-loop branch July 28, 2021 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants