Fix issue with thread-loader + babel-loader performance #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanpenner
requested changes
Jun 22, 2021
| @@ -0,0 +1,17 @@ | |||
| const { applyVariantToBabelConfig } = require('@embroider/core'); | |||
| module.exports = require('babel-loader').custom(babel => { | |||
There was a problem hiding this comment.
A short description of the "fix" would be great. As it may not be obvious for future travelers.
There was a problem hiding this comment.
I added more to commit description
krisselden
force-pushed
the
fix-thread-loader-perf
branch
from
8f585d6
to
a1e4d45
Compare
since thread-loader serializes options per file we only pass the config file and variant to the loader then apply the variant to the config inside the worker.
krisselden
force-pushed
the
fix-thread-loader-perf
branch
from
a1e4d45
to
fbe7dcb
Compare
stefanpenner
approved these changes
Jun 22, 2021
rwjblue
approved these changes
Jun 22, 2021
rwjblue
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avoid sending resolver config per file.