Fix case where autoRun is false but no other addon set content into the {{content-for 'app-boot'}}
#710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I know we poked at this together but I think we'll need a bit more details here before landing. |
string which was being checked for as falsy when it should actually be considered truthy.
rwjblue
reviewed
Mar 4, 2021
| } | ||
|
|
||
| readAppBoot() { | ||
| if (!this.appBoot) { |
There was a problem hiding this comment.
FWIW, the prior guard had issues because in cases where no addon emits {{content-for 'app-boot'}} content the value will be '', which is going to evaluate to falsey.
rwjblue
approved these changes
Mar 4, 2021
rwjblue
changed the title
autoRun is false but no other addon set content into the {{content-for 'app-boot'}}
This was referenced Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
this.appBootis an empty string this would result in a falsy condition when instead it should be considered truthy. This code path is uncovered when autoRun is set to false due to:embroider/packages/core/src/app.ts
Line 1017 in 9d13424