Docs(addon-author-guide)/ remove the out-of-date part about alternative to monorepos #1765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…non-monorepo, this is no longer true
BlueCutOfficial
changed the title
| @@ -67,7 +67,7 @@ Another good way to learn about v2 addons is to look at some examples: | |||
| - [ember-stargate](https://github.com/simonihmig/ember-stargate) | |||
| - [glimmer-apollo](https://github.com/josemarluedke/glimmer-apollo) | |||
|
|
|||
| Several of these examples use a monorepo as a way to keep a clean separation between the addon and the application that holds their test suite. If you're comfortable working with monorepos this is a good solution. On the other hand, monorepos have some tradeoffs and are not always well-supported by all tools, so it's also OK to keep your test app in a subdirectory of your addon. This is closer to how V1 addons work, where `tests/dummy` serves this purpose. See [ember-welcome-page](https://github.com/ember-cli/ember-welcome-page) for an example of not using a monorepo -- instead it has a `test-app` subdirectory and uses the `addon-dev` command from `@embroider/addon-dev` to manage linkage between the addon and the test-app and to manage combining of dependencies from both into a single top-level package.json | |||
| These examples use a monorepo as a way to keep a clean separation between the addon and the application that holds their test suite. This is currently the recommended solution. | |||
There was a problem hiding this comment.
Should probably say why it's recommend or link to something that explains how you want to assure deps and package.json#exports are configured correctly, etc.
Thanks!
There was a problem hiding this comment.
I don't think that should be a blocker for merging this PR 🤔 maybe we can get this merged and we can discuss your point in the meeting tomorrow @NullVoxPopuli ?
Closed
BlueCutOfficial
deleted the
docs-addon-author-guide-remove-out-of-date
branch
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1754
This PR removes the out-of-date paragraph presenting an alternative to monorepos in
addon-author-guide, withember-welcome-pageas an example.ember-welcome-pageis now a monorepo.