Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't rely on htmlbars internals #1743

Merged
merged 3 commits into from
Dec 23, 2023
Merged

Don't rely on htmlbars internals #1743

merged 3 commits into from
Dec 23, 2023

Conversation

ef4
Copy link
Contributor

@ef4 ef4 commented Dec 22, 2023

I'm working on a cleanup in ember-cli-htmlbars that is blocked on embroider touching some internals.

I'm working on a cleanup in ember-cli-htmlbars that is blocked on embroider touching some internals.
}
export default function loadAstPlugins(registry: any): Transform[] {
let plugins = registry.load('htmlbars-ast-plugin').map((wrapper: any) => wrapper.plugin);
plugins.reverse();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why's the reverse needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The plugins in the registry have historically always run in the backwards order for dumb reasons. sigh.

I should make sure the comment doesn't get dropped by this PR though, if you look through the diff you can see the spot where it's getting removed.

@ef4 ef4 added the bug Something isn't working label Dec 23, 2023
ef4 added a commit to ember-cli/ember-cli-htmlbars that referenced this pull request Dec 23, 2023
@ef4 ef4 marked this pull request as ready for review December 23, 2023 17:52
@ef4 ef4 merged commit a47b450 into stable Dec 23, 2023
203 checks passed
@ef4 ef4 deleted the htmlbars-cleanup branch December 23, 2023 17:53
@github-actions github-actions bot mentioned this pull request Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants