Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reorder extension precedence when searching app-js and fastboot-js trees #1664

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

ef4
Copy link
Contributor

@ef4 ef4 commented Nov 14, 2023

As far as I can tell, this should always have been .js before .hbs and we just missed it when adding this.

Copy link
Contributor

@chancancode chancancode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth noting that this was previously said to be deliberate:

da744d9#diff-61967680c203e14cb9a3b2c252caca7d6b0ee9b285991dba6b728f6c54112a12L960-R1032

This order seems wrong, and tests pass, so 👍🏼 but if anyone somehow gets bitten by this, it may be worth tracing it deeper into why the original code had it done this way

@ef4
Copy link
Contributor Author

ef4 commented Nov 14, 2023

The origin was #1463. It was definitely not intentional.

@ef4 ef4 merged commit 6c2f482 into main Nov 14, 2023
204 checks passed
@ef4 ef4 deleted the extension-precedence branch November 14, 2023 21:55
@mansona mansona added the bug Something isn't working label Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants