adjust moved-package-target for namespaced packages #1663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't think this was actually breaking anything but it produced more confusing error messages when a module is missing.
ef4
force-pushed
the
namespaced-moved
branch
from
fd08ea5
to
6ceae64
Compare
void-mAlex
reviewed
Nov 15, 2023
| @@ -52,7 +52,12 @@ ${summarizePeerDepViolations(violations)} | |||
| }); | |||
|
|
|||
| let fakeTargets = Object.values(index.packages).map(dir => { | |||
| return writeFile(join(dir, '..', 'moved-package-target.js'), ''); | |||
| let segments = dir.split('/'); | |||
There was a problem hiding this comment.
@ef4 is it ok for this to not split on sep ?
There was a problem hiding this comment.
I actually tried that first and it breaks, because the index of moved packages here is always assembled in unix format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think this was actually breaking anything but it produced more confusing error messages when a module is missing.