-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor embroider-implicit-modules export pojo #1653
Conversation
lazyEngines, | ||
eagerModules, | ||
styles, | ||
// this is a backward-compatibility feature: addons can force inclusion of modules. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the comment here!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😂 the comment will need to be removed when this file gets coopted to do more stuff, this comment was just brought forward from the bit it was deleted from just above this 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Take this approval with a great of salt, I will trust CI to confirm if the code works, but the changes make sense.
913aee1
to
33572ea
Compare
PR isn't ready yet, we have a lot of tests to fix 🙈
ba2b508
to
0dfeb05
Compare
0dfeb05
to
5800603
Compare
5800603
to
a7bc4cd
Compare
b403fc2
to
9564bd0
Compare
9564bd0
to
cbec5d7
Compare
f73f0d6
to
996aeff
Compare
850b4bc
to
576dedb
Compare
576dedb
to
902e26a
Compare
This PR is part of the work to a) remove the need for rewritten_app and b) eventually support vite