Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase CI timeout #1636

Merged
merged 2 commits into from
Oct 11, 2023
Merged

Increase CI timeout #1636

merged 2 commits into from
Oct 11, 2023

Conversation

chancancode
Copy link
Contributor

The windows watch mode tests takes just about 20 minutes and often get killed when they are just about to finish

The windows watch mode tests takes just about 20 minutes and often get killed when they are just about to finish
@mansona
Copy link
Member

mansona commented Oct 10, 2023

I'm not exactly sure we're seeing a real case of this taking > 10 mins 🤔 I suspect the thing you're going to see is that it's going to get killed when [its] just about to finish but at 20 mins. I don't know why we would be having this issue only with release but I suspect that something isn't cleaning up a stream and that's keeping the subprocess open

Settling an unofficial bet with @mansona
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is obviously needed for our CI but I'm very uncomfortable merging it 🙈

@mansona mansona merged commit 786fccf into embroider-build:main Oct 11, 2023
202 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants