Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add semverRange <=4.11.0 for ember-data #1369

Merged
merged 2 commits into from
Mar 7, 2023

Conversation

mkszepp
Copy link
Contributor

@mkszepp mkszepp commented Feb 28, 2023

fix #1322

Starting with ember-data v4.11.1 there is not anymore necessary to add package rules (emberjs/data#8427)

@SergeAstapov SergeAstapov added the enhancement New feature or request label Feb 28, 2023
@ef4
Copy link
Contributor

ef4 commented Mar 2, 2023

Thanks. Does this means we should be disabling the compat adapters too? There are six ember-data-related ones:

https://github.com/embroider-build/embroider/blob/01575a4d3a86b8b329c75024aa77b2539a6dad5d/packages/compat/src/compat-adapters/ember-data.ts
https://github.com/embroider-build/embroider/tree/main/packages/compat/src/compat-adapters/%40ember-data

If so, here's an example of how a compat adapter can turn off based on the addon version:

static shouldApplyAdapter(addonInstance: any) {
return semver.lt(addonInstance.pkg.version, '4.0.0');
}

@mkszepp
Copy link
Contributor Author

mkszepp commented Mar 3, 2023

@ef4 yes we can disable all adapters, added this lines in PR

@ef4 ef4 merged commit e0fe915 into embroider-build:main Mar 7, 2023
@runspired
Copy link

fwiw probably this is true 4.8+. I think a few of the packages maybe weren't fully converted for 4.8 I'd have to go refresh my memory but it's at least true that far far less was needed for that release. Considering it was LTS we may want to also account for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can't locate @ember-data/record-data/-private referred to in module rules
4 participants