starting to move resolution into an unplugin #1311
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
void-mAlex
reviewed
Dec 20, 2022
Comment on lines
34
to
35
| readJsonSync, | ||
| readJSONSync, |
There was a problem hiding this comment.
turns out fs-extra actually exports both of these as aliases of each other, but it's confusing to see them both imported
There was a problem hiding this comment.
Oh yeah, this is just autocomplete being silly.
ef4
force-pushed
the
refactor-resolution
branch
from
0bb5388
to
c930b4b
Compare
Only babel-plugin-adjust-imports care about relativizing them. Unplugin doesn't want that (and will do the wrong thing with them).
|
Closing in favor of #1331 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.