Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect babel-plugin-ember-template-complation when other plugins are … #1299

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

ef4
Copy link
Contributor

@ef4 ef4 commented Nov 29, 2022

…preventing parallelization

We need to detect and replace the template compilation plugin that is likely to be present in a v1 addon. We were missing one new-ish case:

  • ember-cli-htmlbars 6.0
  • with an ember version that doesn't need the old modulesApiPolyfill
  • when some other babel plugin is preventing ember-cli-babel from parallelizing.

The symptom when this fails is that templates get compiled to wire format too early, so we miss doing staticComponent (and helper and modifier) analysis, so you end up with missing components / helpers / modifiers in a v1 addon at runtime.

Fixes #1296

…preventing parallelization

We need to detect and replace the template compilation plugin that is likely to be present in a v1 addon. We were missing one newish case:
  - ember-cli-htmlbars 6.0
  - with an ember version that doesn't need the old modulesApiPolyfill
  - when some other babel plugin is preventing ember-cli-babel from parallelizing.
@ef4 ef4 merged commit 2275160 into main Nov 30, 2022
@ef4 ef4 deleted the detect-non-parallel-etc branch November 30, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helpers fail to resolve from .hbs.js file with embroider 2.x and static helpers
1 participant