Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow v2 addons to use app tree fallback resolution #1278

Merged
merged 1 commit into from
Nov 16, 2022

Conversation

ef4
Copy link
Contributor

@ef4 ef4 commented Nov 10, 2022

We are careful to not allow most of the bad backward-compatible kinds of package resolution inside v2 addons.

But there's an exception that we need to allow and don't: due to app tree merging, files from a v2 addon can end up needing to resolve back to that v2 addon from the app, even when the v2 addon is not properly resolvable from the app.

This is already handled for v1 addons through a process of attempting to resolve from the app, from the original addon, and then from the global list of all known addons. This change allows v2 addons to also use that process, but only when resolving their own name.

Fixes #1175

We are careful to not allow most of the bad backward-compatible kinds of package resolution inside v2 addons.

But there's an exception that we need to allow and don't: due to app tree merging, files from a v2 addon can end up needing to resolve back to that v2 addon from the app, even when the v2 addon is not properly resolvable from the app.

This is already handled for v1 addons through a process of attempting to resolve from the app, from the original addon, and then from the global list of all known addons. This change allows v2 addons to also use that process, but only when resolving their own name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v2 addon files not resolvable when brought into app through v1 addon
1 participant