Merge pull request #874 from thoov/cleanup-sample-lib

embroider-build · Jun 24, 2021 · 1bb796a · 1bb796a
2 parents c7f90cc + 9bbbfd6
commit 1bb796a
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 14 deletions.
diff --git a/test-packages/sample-lib/index.js b/test-packages/sample-lib/index.js
diff --git a/test-packages/sample-lib/package.json b/test-packages/sample-lib/package.json
diff --git a/tests/scenarios/fastboot-app-test.ts b/tests/scenarios/fastboot-app-test.ts
@@ -1,13 +1,20 @@
 import { appScenarios } from './scenarios';
-import { PreparedApp } from 'scenario-tester';
+import { PreparedApp, Project } from 'scenario-tester';
 import { setupFastboot } from './helpers';
 import QUnit from 'qunit';
 import merge from 'lodash/merge';
 const { module: Qmodule, test } = QUnit;
 
 appScenarios
   .map('dynamic-import', project => {
-    project.linkDependency('@embroider/sample-lib', { baseDir: __dirname });
+    let sampleLib = new Project('@embroider/sample-lib', '0.0.0');
+    merge(sampleLib.files, {
+      'index.js': `export default function () {
+        return 'From sample-lib';
+      }`,
+    });
+
+    project.addDependency(sampleLib);
     project.linkDependency('ember-cli-fastboot', { baseDir: __dirname });
     project.linkDependency('fastboot', { baseDir: __dirname });
     project.linkDependency('fastboot-addon', { baseDir: __dirname });

diff --git a/tests/scenarios/package.json b/tests/scenarios/package.json
@@ -18,7 +18,6 @@
   },
   "license": "MIT",
   "devDependencies": {
-    "@embroider/sample-lib": "link:../../test-packages/sample-lib",
     "@embroider/macros": "0.42.2",
     "bootstrap": "^4.3.1",
     "broccoli-funnel": "^3.0.5",

diff --git a/yarn.lock b/yarn.lock
@@ -1311,9 +1311,6 @@
     resolve "^1.8.1"
     semver "^7.3.2"
 
-"@embroider/sample-lib@link:test-packages/sample-lib":
-  version "0.0.0"
-
 "@embroider/shared-internals@0.41.0":
   version "0.41.0"
   resolved "https://registry.yarnpkg.com/@embroider/shared-internals/-/shared-internals-0.41.0.tgz#2553f026d4f48ea1fd11235501feb63bf49fa306"