Rollup breaks CSS imports for non-entrypoint modules

[simonihmig]

When you have a component that

• imports CSS, like import './foo.css';
• and is not an entrypoint to rollup (like a private component in src/-private/foo.gjs that is imported and used internally)

then rollup would

• move that component module around (component is in /dist/foo-<randomnumbers>.js)
• leave the CSS in place (/dist/-private/foo.css)
• and not rewrite the import (still import './foo.css';)

so webpack (in the consuming app) would expectedly throw an error.

It can be worked around by making all modules entrypoints (like addon.publicEntrypoints(['**/*.js'])). Addons could still limit the public/importable modules through package.json#exports.

Not sure if that's something we should move to?

[ef4]

Not sure if that's something we should move to?

No, we should not make every module an entrypoint.

This is a bug in @embroider/addon-dev's keepAssets.