Implement RFC#1006, Deprecate (action) and {{action}}
#20653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
changed the title
(action) and {{action}} (action) and {{action}}
This was referenced Mar 5, 2024
NullVoxPopuli
force-pushed
the
deprecate-action
branch
from
cb5644b
to
0518131
Compare
kategengler
reviewed
Mar 9, 2024
phndiaye
approved these changes
Mar 10, 2024
11 tasks
|
Should the available/whatever flags be 5.9 or 5.10? |
|
At a first pass the implementation seems good. I guess we should make sure the deprecation URL is live before we merge this. |
|
I agree with @ef4, but syncing that is why we have "Ready for Release". I think this either needs a feature flag or the RFC needs to be in "Ready for Release" to merge. |
kategengler
reviewed
Mar 14, 2024
NullVoxPopuli
force-pushed
the
deprecate-action
branch
2 times, most recently
from
0b5c2f7
to
db0f0d8
Compare
NullVoxPopuli
force-pushed
the
deprecate-action
branch
from
db0f0d8
to
567dc6a
Compare
kategengler
approved these changes
Mar 28, 2024
packages/@ember/-internals/glimmer/tests/integration/components/input-angle-test.js
Outdated
Show resolved
Hide resolved
| expectDeprecation( | ||
| /Usage of the `\(action\)` helper is deprecated./, | ||
| DEPRECATIONS.DEPRECATE_TEMPLATE_ACTION.isEnabled | ||
| ); |
There was a problem hiding this comment.
Should this test be converted to using functions?
There was a problem hiding this comment.
fair enough, updated!
packages/@ember/-internals/glimmer/tests/integration/components/input-curly-test.js
Outdated
Show resolved
Hide resolved
|
Thank you, set automerge! |
6 tasks
This was referenced Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC: emberjs/rfcs#1006
Pending: emberjs/rfcs#1006I was was going through implementing the removal of all this code in a later PR (for v6), I (re?)learned that by deprecating
(action)and{{action}}we shadow-deprecate theactions: {}hash in classic.Should that have its own deprecation RFC?